search

Geequlim / ECMAScript

Javascript binding for godotengine
MIT License
959 stars 84 forks source link

Godot 4 Builds via Github Actions #149

Closed animanmaster closed 1 year ago

animanmaster commented 1 year ago

These changes managed to get me working Godot 4 + Ecmascript builds via Github Actions. I've only done light testing with the Windows editor build and my own project, so definitely needs more testing to make sure everything works as expected, and there's more cleanup work that should be done to the Github Actions, but I figured I'd make this PR in case it helps/inspires others to take it further. :)

animanmaster commented 1 year ago

Also just now realized there's a script that generates the Github Actions from the main repo 🤦 Probably would've saved a few commits if I just read the README fully 🙃 Will try that out to see if gives a cleaner result than the manual edits I did here. 🤞

Geequlim commented 1 year ago

Good work! Can you git squash commits ?

fire commented 1 year ago

@animanmaster Are you able to work on this in the next two weeks?

fire commented 1 year ago

Thanks for your work. @Geequlim @animanmaster

As https://github.com/Geequlim/ECMAScript/pull/150 is merged, this can be closed.

fire commented 1 year ago

Thanks!

animanmaster commented 1 year ago

Sorry for the delay, thanks for picking this up @fire.