Geequlim / ECMAScript

Javascript binding for godotengine
MIT License
959 stars 84 forks source link

feat: improve pipeline to publish release builds #170

Closed nmerget closed 11 months ago

nmerget commented 11 months ago

Add additional workflow_call to publish build artifacts for releases

fire commented 11 months ago

Typical Godot Engine style is to use one commit because it makes code review easy to see, but it is opposite to common practice of showing historical work. Either style is acceptable. The pipeline appears to work. I'll go download the binary and report back.

fire commented 11 months ago

An initial screenshot works.

image

I would merge and work onwards since the cicd passes. I'm sure there'll be more bugs found when interacting with code.