search

GeertBellekens / Enterprise-Architect-Add-in-Framework

Framework for add-ins on Sparx Systems Enterprise Architect
http://geertbellekens.github.com/Enterprise-Architect-Add-in-Framework/
BSD 2-Clause "Simplified" License
70 stars 42 forks source link

Dev #12

Closed NateFen closed 5 years ago

NateFen commented 5 years ago

Hello Geert,

I appreciate you reviewing the PR; However, the changes made are very much a work in progress and were actually intended to be pushed to a forked repo. My apologies for taking up your time.

Thanks, Nate

On Fri., Mar. 8, 2019, 5:20 a.m. Geert Bellekens, notifications@github.com wrote:

@GeertBellekens requested changes on this pull request.

Hi thanks for the pull request. I just found a few things that I need to get changed before I can merge it into the main repository:

  • EAAddinFramework/Databases/Table.cs : line 223. Table is always valid? That can't be right.
  • EAAddinFramework/Databases/DatabaseFactory.cs line 139: please remove comment line
  • EAAddinFramework/EAWrappers/Model.cs: line 185. Why is the exception swallowed here? I don't think we should swallow exceptions in the framework. If needed they can be swallowed in the using code

Regards

Geert

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/GeertBellekens/Enterprise-Architect-Add-in-Framework/pull/12#pullrequestreview-212221039, or mute the thread https://github.com/notifications/unsubscribe-auth/ArfHgK5WzeSPT1rQohhvi1vu4kqAJy6vks5vUjligaJpZM4bj5Xd .

GeertBellekens commented 5 years ago

Alright, no worries.

Geert Bellekens

Sparx Systems Enterprise Architect consultant

Sparx Systems Value Added Reseller

geert@bellekens.com ⚫+32 (0)497 83 44 10 Weldadigheidsstraat 83 ⚫ 2540 Hove ⚫ Belgium

http://bellekens.com

On Fri, Mar 8, 2019 at 3:24 PM Nathaniel Fenwick notifications@github.com wrote:

Hello Geert,

I appreciate you reviewing the PR; However, the changes made are very much a work in progress and were actually intended to be pushed to a forked repo. My apologies for taking up your time.

Thanks, Nate

On Fri., Mar. 8, 2019, 5:20 a.m. Geert Bellekens, < notifications@github.com> wrote:

@GeertBellekens requested changes on this pull request.

Hi thanks for the pull request. I just found a few things that I need to get changed before I can merge it into the main repository:

  • EAAddinFramework/Databases/Table.cs : line 223. Table is always valid? That can't be right.
  • EAAddinFramework/Databases/DatabaseFactory.cs line 139: please remove comment line
  • EAAddinFramework/EAWrappers/Model.cs: line 185. Why is the exception swallowed here? I don't think we should swallow exceptions in the framework. If needed they can be swallowed in the using code

Regards

Geert

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/GeertBellekens/Enterprise-Architect-Add-in-Framework/pull/12#pullrequestreview-212221039 , or mute the thread < https://github.com/notifications/unsubscribe-auth/ArfHgK5WzeSPT1rQohhvi1vu4kqAJy6vks5vUjligaJpZM4bj5Xd

.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/GeertBellekens/Enterprise-Architect-Add-in-Framework/pull/12#issuecomment-470945307, or mute the thread https://github.com/notifications/unsubscribe-auth/AAlkbnkiq5UdvzTqLc4NzJyo4ltW8kuvks5vUnKRgaJpZM4bj5Xd .