GeertJohan / gomatrix

Displays "The Matrix" in a terminal
BSD 2-Clause "Simplified" License
293 stars 68 forks source link

add go.mod and refactor code #13

Closed robatipoor closed 5 years ago

GeertJohan commented 5 years ago

Nice clean up, it's been a long time since I wrote this code, I barely recognize it, haha.

One thing should probably be changed though. setSizes is a method on sizes, but also returns the same sizes.. That's kind of strange. I'd prefer it to not return the sizes object. Then use it like this:

curSizes.setSizes(screen.Size())
sizesUpdateCh <- curSizes
robatipoor commented 5 years ago

Yes you are right please review again commit

GeertJohan commented 5 years ago

Looks good, thanks!