Hidden objects in layer groups are now ignored

GeertWille / sketch-export-assets

Export assets for Android, iOS, Windows Phone in Sketch

GNU General Public License v3.0

434 stars 66 forks source link

Hidden objects in layer groups are now ignored #41

Closed iamaaronmartin closed 8 years ago

iamaaronmartin commented 8 years ago

I used to have a hidden box layer in a layer group that sized and aligned my assets; now it is ignored and the asset is only objects that are turned on. Is this another wonder feature in 3.4 that they didn't tell anyone about?

GeertWille commented 8 years ago

Is it possible to use a slice slayer instead?

iamaaronmartin commented 8 years ago

Do you have specs on what my layer would have to be named? I tried "slicelayer" already and it's ignored as well.

iamaaronmartin commented 8 years ago

I see what you mean now, an actual Sketch slice. Wasn't this working without this in a previous build? I'd been successfully doing this for months without a slice layer. Including the slice layer also exports any backgrounds my assets are on top of (i.e. a white icon on a grey background so as to see the design).

GeertWille commented 8 years ago

@iamaaronmartin yes it was working like that before but I changed it since some people wanted to trim transparant pixels and other didn't... Normally I fixed the problem that assets underneath your asset that will be sliced is included in the export when using a "Sketch slicelayer"... Can you confirm?

iamaaronmartin commented 8 years ago

Using the Sketch slice layer does indeed include anything visually below the folder that is being exported.

GeertWille commented 8 years ago

Did you update before answering?

iamaaronmartin commented 8 years ago

Updated to the latest plugin and added a Sketch slice to the group. Now the whole screen goes white (all layers are hidden except for slice layers) and nothing is exported.

czak commented 8 years ago

I believe I have the same problem.

My file:

screen shot 2016-01-08 at 10 52 16

I want to export the icons with transparent pixels intact and I can't. I also have a locked "Box" layer for sizing.

Tried the following:

selecting the artboard - results in empty PNG files
selecting the slice - results in empty PNG files
selecting the group - results in trimmed PNG files, ignoring the empty Box layer

See the .sketch file.

GeertWille commented 8 years ago

Mhh weird... I just noticed I had sketch 3.4.2 installed and with that it worked fined... I updated to 3.4.4 now and I'll look into it...

gabrielsantos commented 8 years ago

I have the same problem. I'm now forced to create a slice in every single icon (out of the box Sketch functionality).

GeertWille commented 8 years ago

Should be fixed now