search

GeethanadhP / xml-avro

Convert XSD -> AVSC and XML -> AVRO
Apache License 2.0
36 stars 26 forks source link

Upgraded libraries (snakeyaml up to version 1.18), fix compilation errors #22

Closed fernaspiazu closed 4 years ago

fernaspiazu commented 5 years ago

This PR contains an upgrade of some libraries, in particular Scala to the last 2.12.x version.

GeethanadhP commented 5 years ago

Did you test it out??, last time i tried to update the avro versioin to 1.8, i got a bunch of issues

fernaspiazu commented 5 years ago

Hi @roycem90, There's no a test suite to run unfortunately. Nevertheless I launched every config.yml I found under example/ and src/test/resources/ folders, and there are 2 tests that do not work, in both branches master and upgrade-dependencies (mine).

which brings me to the conclusion that upgrade dependencies won't break existing code.

If you want, you can try to test both branches and compare them, as I did 😊 Thanks in advance and let me know 😉 Cheers.