Geforce132 / SecurityCraft

Source code for the Minecraft mod "SecurityCraft".
MIT License
130 stars 81 forks source link

Compat. Oddities with "WATERFrAMES: Media Displays" and "Create: The factory must grow!" - FYI #520

Open DurpyFlabergazm opened 1 month ago

DurpyFlabergazm commented 1 month ago

Issue description

Appears Security Cameras alongside mods like "WATERFrAMES: Media Displays" and "Create: The factory must grow!" can act weird. Found that using a camera and looking at certain objects cause them to:

Be immortal (mine block and it pops right back)

Duplicates its audio (Frames Display Project did this, also became immortal)

A curious predicament. Can fix by using camera again after attempt to mine block was made and it vanishes... after another swipe of the mining

Whether it gets fixed or not too biggy. I'll either build around it or just avoid using them together. But now you know if you didn't! Thanks for Reading!

Steps to reproduce

Place Light Bulb from "Create: Factory must grow!" Place Projector from "WATERFrAMES: Media Displays" Add URL to Projector to display, make sure audio is enabled, press play Place Camera within view of Displayed Video or Light Bulb Do your thing (connect cameras to thinga majig... forgot what it called :O ) View

If light bulb doesn't act weird for you, try and flip it on and off using Redstone while viewing (looped circuit)

Fix, Mine block. Open Camera again, Exit Camera Attempt to mine immortal block again

Minecraft version

1.20.1

Forge/NeoForge version

Forge - 47.3.0

SecurityCraft version

v1.9.10

Other relevant versions

WATERFrAMES: Media Displays - Version: Forge-v2.0.11a Create: The Factory Must Grow - Version: Forge-tfmg-v0.9.0d

If a (crash)log is relevant for this issue, link it here: (It's almost always relevant)

No response

bl4ckscor3 commented 1 month ago

Hm, weird. I can't think of something that would be causing this, since we just load chunks normally for players viewing a camera. Thanks for bringing this to our attention.

SrRapero720 commented 1 month ago

Waterframes unloads the displays when level is cleaned or when tile gets destroyed or unloaded, ignoring chunk unloading

Assuming you attempt to load a loaded chunk, probably is triggeringn 2 times the tile creation on client-side.

(I didnt tested this yet)