Gegy / tic-tacs

Experimental mod to improve Minecraft's chunk loading performance as well as allow for multithreading. Currently inactive.
GNU Lesser General Public License v3.0
153 stars 12 forks source link

Extreme fps lag and chunks not rendering properly #18

Open Snivine opened 4 years ago

Snivine commented 4 years ago

When playing on singleplayer the chunks don't render properly and there's extreme fps lag My hardware if you need it: CPU: Intel Celeron N3060 GPU: Intel HD Graphics 400 RAM: 4GB DDR3L 1600mhz

Screenshots: 2020-10-23_12 06 04 2020-10-23_12 06 24 2020-10-23_12 06 28

Gegy commented 4 years ago

Hi, thanks for the report :) Which version of the mod is this with?

Snivine commented 4 years ago

it's 0.1.2

Gegy commented 4 years ago

Okay- interesting, will have to investigate further.

Snivine commented 4 years ago

if you wonder I'm running the mod with lithium and sodium, I don't know if that could have something to do

Snivine commented 4 years ago

You have old, low-end hardware and are trying to run high end graphics, possibly fabulous shaders. What you're trying to run requires high-end hardware. Of course you're getting lag and chunks not rendering. I don't understand how no-one can understand this. No wonder some ppl are laughing at this bug report on discord. This feels like a joke post from reddit. You either need to run fast graphics without fancy clouds on render distance 8 or accept that this will constantly happen. Even I don't get 60fps 100% of the time on 1-2 year old mid-range hardware. What makes you think you can?

You're assuming my graphics settings, not only that you're spreading bullshit because I'm pretty sure a 2016 CPU still not old, this PC can run the game with Lithium+Phosphor+Sodium at stable 40 FPS, I have EVERYTHING on fast, and this lag doesn't happens normally, please ask first and then comment, don't just assume. IMG_20201023_123058 ![Uploading IMG_20201023_123054.jpg…]()

Snivine commented 4 years ago

IMG_20201023_124142

ghost commented 4 years ago

When playing on singleplayer the chunks don't render properly and there's extreme fps lag My hardware if you need it: CPU: Intel Celeron N3060 GPU: Intel HD Graphics 400 RAM: 4GB DDR3L 1600mhz

Screenshots: 2020-10-23_12 06 04 2020-10-23_12 06 24 2020-10-23_12 06 28

I have a laptop with such specs(except the ram is different),sometimes chunks don't load (or something because pushing entities through them makes them stuck) I am not sure if it happens in the latest release, at some point, I will test and report back. as for the fps lag,I am not sure what is causing it for you (it may be tic-tacs and it may not be)-I have to do more testing to see if it happens to me- have you tried playing the game with only tic-tacs, sodium and lithuim if the lag still happens then we maybe can say it is from tic-tacs, after that, you can try adding phosphor because it may help you.

ghost commented 4 years ago

I did some testing, not very scientific but still, I got some results, I'll lay them out: I have gone through phases of testing:(All mods are up to date from curseforge except for tic-tacs which was from GitHub, and the fabric mod loader is up to date) I was using:

Operating System: Manjaro Linux
Kernel Version: 5.9.1-1-MANJARO
OS Type: 64-bit
Processors: 2 × Intel® Celeron® CPU N3060 @ 1.60GHz
Memory: 1,9 GiB of RAM(2GB of ram)
Graphics Processor: Mesa DRI Intel® HD Graphics 400

used the bundled jre. and these jvm arguments: -Xmx1G -XX:+UnlockExperimentalVMOptions -XX:+UseG1GC -XX:G1NewSizePercent=20 -XX:G1ReservePercent=20 -XX:MaxGCPauseMillis=50 -XX:G1HeapRegionSize=32M PHASE1:LITHIUM + SODIUM + TIC-TACS + FABRIC API Didn't test with this configuration much but here is what I noticed: I flew around in creative after a bit of flying I noticed a bit of terrain not rendering(blocks seem to be there and I can break them) switching the rendering backend to opengl 3.0 rendered a bit of terrain and then to 2.0 the same bit got rerendered and switching back to 4.3 the same bit got rendered. quitting from the world and then opening it again rendered the chunks properly(Not sure about f3+a) 2020-10-30_12 38 05 in the image, it doesn't show well but blocks were pointable. PHASE2:LITHIUM + TIC-TACS + FABRIC API(sodium removed) I flew around, didn't notice any terrain that was loaded yet not rendered but I noticed some chunks that weren't loaded in the first place: 2020-10-30_12 55 31 2020-10-30_12 55 36 2020-10-30_12 57 46 2020-10-30_12 58 12 2020-10-30_12 59 16 2020-10-30_13 00 04 Not sure if I would encounter chunks that are loaded but not rendered if I would have played for longer. PHASE3: TIC-TACS + FABRIC API(lithium removed) I flew around for a bit, and found some chunks that aren't loaded, 2020-10-30_14 28 47 quitting and entering the world fixed them. I realised "chunks that aren't loaded" may not be the correct term because I can stand in them, there seems to be terrain but it behaved like ghost blocks because entities bounce up and down when they stand on them(These are observations from the chunks I found in phase 3, but I think they apply to phase 2-I could be wrong-) to conclude there seems to be an issue but I can't really say for sure because the tests where not that scientific and the results may be completely inaccurate and I may have forgot something or reported something wrongly, so take them with a pinch of salt.

TerdyTheTerd commented 3 years ago

Using a multi-threaded chunk loading mod on a mobile CPU with only 2 cores is at least a 5Head move, Big Brain Plays

DragonEggBedrockBreaking commented 3 years ago

Using a multi-threaded chunk loading mod on a mobile CPU with only 2 cores is at least a 5Head move, Big Brain Plays

Isn't multithreading optional?

"Tic-TACS additionally enables optional multithreading of chunk loading which can bring significant improvement in generation speed, as well as allowing for much higher chunk view distances."

Snivine commented 3 years ago

on Windows 10 this issue doesn't happens, tho the FPS lag still there but that's with phosphor and lithium only

On Sat, Dec 12, 2020, 11:20 AM DragonEggBedrockBreaking < notifications@github.com> wrote:

Using a multi-threaded chunk loading mod on a mobile CPU with only 2 cores is at least a 5Head move, Big Brain Plays

Isn't multithreading optional? [image: image] https://user-images.githubusercontent.com/68545280/101990329-4a101780-3c9e-11eb-8288-0ad9f75dba39.png

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Gegy/tic-tacs/issues/18#issuecomment-743786609, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARFXKA2TNRKD6D4QXGNGZQ3SUOQ55ANCNFSM4S4377HA .

Snivine commented 3 years ago

2020-12-14_15 15 45 nope it still happens, bear in mind that I disabled multithreading

EcoBuilder13 commented 3 years ago

This is much larger than just a rendering bug. I just encountered this on my server. Multiple people see the missing chunks and broken entities around the chunk. While the chunk loading was broken we were able to place blocks of sand in the air and place blocks which were invisible to other people. After a while the server reported that we went into unloaded chunks and would prevent us from joining the server. I then proceeded to try and shutdown the server but this bug caused the server to no longer respond to commands. I eventually had to try kill the process with it's pid and the server will not shutdown. I ended up having to restart my entire server which successfully shutdown the Minecraft server.

Snivine commented 3 years ago

This is a vanilla issue, but Tic-TACS makes it easier to occur, I think that Tic-TACS uses more resource than vanilla Minecraft, making it easier to overhead, so I don't know what could be done in this case, maybe find out why it uses more resources?

EcoBuilder13 commented 3 years ago

@Snivyer1910 Do you know if this has been reported on the Mojang bug tracker?

Snivine commented 3 years ago

I don't know but sapnap experienced this same issue in 100% vanilla

EcoBuilder13 commented 3 years ago

Do you know what version of the game they used? I also found MC-146778 and MC-138114 but it might still be broken.

Snivine commented 3 years ago

they where using 1.16, I don't know the patch number tho, but I'll guess 1.16.1 bc it was a speedrun

On Sun, Jan 3, 2021, 3:25 PM EcoBuilder13 notifications@github.com wrote:

Do you know what version of the game they used? I also found MC-146778 https://bugs.mojang.com/browse/MC-146778 and MC-138114 https://bugs.mojang.com/browse/MC-138114 but it might still be broken.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Gegy/tic-tacs/issues/18#issuecomment-753678360, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARFXKA5NVX4PURVWVUQKCTLSYDODDANCNFSM4S4377HA .

EcoBuilder13 commented 3 years ago

I have found that unloading all of the broken chunks then reloading them fixes the errors, but if any player still has them loaded in on server side any player which comes near the chunks will see the error too. It might be possible to unload then reload all the chunks around a player when the game warns of the player entering unloaded chunks. I have noticed this occasionally happens when players near or enter the broken chunks.

RangoMcRoony commented 3 years ago

Same issue occuring for me too. Chunks just refuse to load, F3+A doesn't do much. Restarting the server or world seems to be the only way to fix this. U wasn't sure if this was an issue with Tic-TACS or with starlight but since other people are experiencing this it seems to be a Tic-TACS issue

EcoBuilder13 commented 3 years ago

@RangoMcRoony You can also "fix" it on dedicated servers if all the players disconnect and reconnect that are near the broken chunks. This seems to be a problem with the server not sending the chunks to the client correctly. Which is still possible in single player since the game just runs an internal server you connect to.

DragonEggBedrockBreaking commented 3 years ago

on Windows 10 this issue doesn't happens, tho the FPS lag still there but that's with phosphor and lithium only

I use windows, and it it the other way around for me; chunks don't load but the FPS is fine.