GehirnInc / python-jwt

JSON Web Token library for Python

https://pypi.python.org/pypi/jwt

Apache License 2.0

145 stars 30 forks source link

AbstractJWKBase Should be an ABC class #20

Closed sjortiz closed 5 years ago

sjortiz commented 5 years ago

Rationale

AbstractJWKBase so far is just a placeholder class that raise not implemented if a method is called in a subclass that doesn't implement the given method, this is exactly why ABC classes in python are for, therefore we should move it that way.

https://github.com/GehirnInc/python-jwt/blob/master/jwt/jwk.py#L53

sjortiz commented 5 years ago

@yosida95 I would like to work on this issue myself

yosida95 commented 5 years ago

@sjortiz

Thank you for your suggestion! Your point is correct.

I will wait for your patch on this for a month.