Geigerkind / DPSMate

A wow 1.12.1 combat analyzation tool
https://legacyplayers.com
GNU General Public License v3.0
90 stars 29 forks source link

Events not parsed yet #204

Open WouterBink opened 5 years ago

WouterBink commented 5 years ago

Bunch of missing parses in Molten Core on Kronos 3 with the latest version:

Event not parsed yet, inform Shino! => \<character> resists \<character>'s Thorns.

Event not parsed yet, inform Shino! => \<any totem> is destroyed.

Event not parsed yet, inform Shino! => \<character> 's Volley was resisted by \<character>.

Event not parsed yet, inform Shino! => \<character> 's Explosive Trap Effect was resisted by \<character>.

Event not parsed yet, inform Shino! => Shazzrah interrupts \<character> 's \<any spell>.

Event not parsed yet, inform Shino! => You attack but \<character> is immune.

Also, you might want to limit duplicate messages, as they can get kinda spammy.

Road-block commented 5 years ago

DPSMate: 11: Event not parsed yet, inform Shino! => Greater Lava Spider 's Fireball was resisted by Whistle.

With DPSMate Build 130 Beta 11
Whistle in the message is hunter pet.

Geigerkind commented 5 years ago

@WouterBink It would help tremendously if you would also link the number like Roudblock did.

Geigerkind commented 5 years ago

@Road-block fixed

Geigerkind commented 5 years ago

Will keep this open for now, incase Wouter responses :)

WouterBink commented 5 years ago

Will use the new version during next week's raid and update with any remaining issues and their error codes.

Road-block commented 5 years ago

I wasn't able to save the exact message but my taunts while in a 5man group cause an event not parsed yet with latest DPSMate Build 130 Beta 12 I'll update this with the debug text next I have a chance.

bohdanpopovych commented 5 years ago

image Same

bohdanpopovych commented 5 years ago

Happens as well when target is immune to attacks, will try to provide a screen

bohdanpopovych commented 5 years ago

image Loyalty - player(warlock)

bohdanpopovych commented 5 years ago

image

bohdanpopovych commented 5 years ago

image

herkan commented 5 years ago

4b8e52fa1c218662cd7c3a07e3852063

0de82e48d8e9e83afce557d9719c5f3b

DPSMate Build 130 Beta 12

Geigerkind commented 5 years ago

@herkan fixed @bohdanpopovych fixed

Please retest with latest master

bohdanpopovych commented 5 years ago

image

Road-block commented 5 years ago

Unfortunately I wasn't able to update before my raid earlier so these are for DPSMate Build 130 Beta 12

DPSMate: 11: Event not parsed yet, inform Shino! => Zulian Panther 's Rake was blocked.
DPSMate: 16: Event not parsed yet, inform Shino! => Atal'ai Mistress 's Blessing of Sacrifice causes Implius 0 damage.
DPSMate: 16: Event not parsed yet, inform Shino! => Corrupted Infernal 's Blessing of Sacrifice causes Implius 0 damage.
DPSMate: 16: Event not parsed yet, inform Shino! => Voodoo Slave 's Blessing of Sacrifice causes Implius 0 damage.
DPSMate: 16: Event not parsed yet, inform Shino! => Voodoo Slave 's Blessing of Sacrifice causes Implius 55 damage.
DPSMate: 16: Event not parsed yet, inform Shino! => Withered Mistress 's Blessing of Sacrifice causes Implius 0 damage.
DPSMate: 16: Event not parsed yet, inform Shino! => Withered Mistress 's Blessing of Sacrifice causes Implius 55 damage.
DPSMate: 2: Event not parsed yet, inform Shino! => You attack but Corrupted Infernal is immune.
DPSMate: 3: Event not parsed yet, inform Shino! => You perform Taunt on Corrupted Infernal.
DPSMate: 3: Event not parsed yet, inform Shino! => You perform Taunt on Gurubashi Berserker.
DPSMate: 3: Event not parsed yet, inform Shino! => You perform Taunt on Hakkari Priest.
DPSMate: 3: Event not parsed yet, inform Shino! => You perform Taunt on Hakkari Shadow Hunter.
DPSMate: 3: Event not parsed yet, inform Shino! => You perform Taunt on High Priestess Arlokk.
DPSMate: 3: Event not parsed yet, inform Shino! => You perform Taunt on Jin'do the Hexxer.
DPSMate: 3: Event not parsed yet, inform Shino! => You perform Taunt on Shade of Jin'do.
DPSMate: 3: Event not parsed yet, inform Shino! => You perform Taunt on Withered Mistress.
DPSMate: 3: Event not parsed yet, inform Shino! => You perform Taunt on Zulian Tiger.
Road-block commented 5 years ago

This is btw a log of errors with a multitude of duplicates removed.
At the current state of the addon (at least the beta 12 state) it pretty much disables the default chatframe in raids as it's impossible to read anything else through all the spam.

An ancillary question: Does the latest RPLLVanilla + RPLLLauncher.jar require the post-rewrite DPSMate to work or is it independent?

Road-block commented 5 years ago

DPSMate: 11: Event not parsed yet, inform Shino! => Heavy War Golem 's Trample was blocked.
with DPSMate Build 130 Beta 14

Road-block commented 5 years ago

Taunt event not parsed from above is still valid for DPSMate Build 130 Beta 14

bohdanpopovych commented 5 years ago

image

bohdanpopovych commented 5 years ago

image

WouterBink commented 5 years ago

Using b130beta14: DPSMate: 19: Event not parsed yet, inform Shino! => \<character\> resists \<character\>'s Thorns.

DPSMate: 30: Event not parsed yet, inform Shino! => \<any totem\> is destroyed.

DPSMate: 4: Event not parsed yet, inform Shino! => \<character\> 's Explosive Trap Effect was resisted by \<character\>.

DPSMate: 4: Event not parsed yet, inform Shino! => \<character\> 's Flamestrike was resisted by \<character\>.

While I was not able to reconfirm the Volley resist issue, I would guess it's also number 4.

Also, got a new(? might have just not noticed earlier) error on both Firelord trash and Baron Geddon: DPSMate: Ab/Cause/Duser/amount: one of them is nil: AutoAttack/Baron Geddon/NONE/0

Geigerkind commented 5 years ago

@WouterBink @Road-block @bohdanpopovych Fixed the reported issues, please retest!

lvangh commented 5 years ago

here's another: image

lvangh commented 5 years ago

More: image

Road-block commented 5 years ago

Out of curiosity are those mind-controlled npcs fighting other npcs?

lvangh commented 5 years ago

Mind Control,

Also seeing this on a Warlock when VW uses the HP regen spell. Using latest release w/ clean install.

image

Geigerkind commented 5 years ago

@lvangh , can u get me the combat log message for this warlock event?

Geigerkind commented 5 years ago

Fixed other reports, please test!

herkan commented 5 years ago

ff2078e1b41527f9e39654fdf66a84cf

2479a7a13a609bc9f396b975c9c26ac6

1adbfaddbc2bea2fff8d8ba17eeeecc8

128fa68c3e22a91d1e6f25223adf52c0

0b0dda9197527600484bcd9e27098c0f

Newest version

Road-block commented 5 years ago

You perform Taunt on <enemy> still happens in beta16.
I also got a parse failure on You dodged <enemy>'s Disarm

Finally a parserEN_US actual Lua error which unfortunately I lost to a client crash.

Geigerkind commented 5 years ago

@herkan Im going to need the event for the Ab/Cause error if you can @Road-block Is that event 3? I have no idea why it isnt parsed :/

Geigerkind commented 5 years ago

Actually I just noticed what caused the issue with perform.

Geigerkind commented 5 years ago

Okay please update and test again

bohdanpopovych commented 5 years ago

image On beta17 =(

bohdanpopovych commented 5 years ago

And still have this on b16 image

herkan commented 5 years ago

DPSMate build: 130

Dec/13 20:14:56 - 6: Event not parsed yet => Mad Voidwalker is immune to Foortune 's Thorium Grenade. Dec/13 20:28:17 - 6: Event not parsed yet => Gurubashi Champion is immune to Vesri 's Earthshaker. Dec/13 20:40:26 - 6: Event not parsed yet => Bloodseeker Bat is immune to Vymi 's Iron Grenade. Dec/13 20:40:30 - 6: Event not parsed yet => Gurubashi Bat Rider is immune to Vymi 's Intercept Stun.

Geigerkind commented 5 years ago

@Road-block @herkan @bohdanpopovych fixed please retest

herkan commented 5 years ago

DPSMate build: 130 beta 18

Dec/16 14:11:57 - 19: Event not parsed yet => Lio 's Dispel Magic is reflected back by Azuregos. Dec/16 14:12:23 - 11: Event not parsed yet => You resist Azuregos 's Manastorm. Dec/16 22:54:03 - 16: Event not parsed yet => Hakkari Priest is immune to Nakz 's Cheap Shot. Dec/16 22:54:04 - 16: Event not parsed yet => Hakkari Priest is immune to Frezza 's Cheap Shot.

bohdanpopovych commented 5 years ago

image beta18

Road-block commented 5 years ago

DPSMate build: 130 beta 18

Dec/16 23:05:09 - 16: Event not parsed yet => Gurubashi Bat Rider is killed by Unstable Concoction. Dec/16 23:17:10 - 3: Event not parsed yet => You resisted your Flames.

laiprorus commented 5 years ago

image

lvangh commented 5 years ago

DPSMate build: 130

Dec/18 19:44:13 - 12: Event not parsed yet => Young Pridewing 's Poison was resisted by Freechicken. Dec/18 19:51:17 - 12: Event not parsed yet => Venture Co. Deforester 's Rain of Fire was resisted by Freechicken. Dec/18 20:11:49 - 12: Event not parsed yet => Pridewing Wyvern 's Poison was resisted by Freechicken.

lvangh commented 5 years ago

DPSMate build: 130

Dec/20 15:56:31 - 6: Event not parsed yet => You resist [player]'s Entangling Roots. Dec/20 16:07:52 - 11: Event not parsed yet => You resist [players] Entangling Roots. Dec/20 16:08:25 - 19: Event not parsed yet => You resist [players] Thorns.

Road-block commented 5 years ago

image

shawndalton commented 5 years ago

DPSMate build: 130

Dec/21 00:26:20 - 16: Event not parsed yet => Gurubashi Bat Rider is killed by Unstable Concoction. Dec/21 00:30:46 - 16: Event not parsed yet => Bloodseeker Bat 's Fixate was evaded by Bloodseeker Bat. Dec/21 00:36:36 - 19: Event not parsed yet => [player] 's Holy Shock was evaded by Hooktooth Frenzy.

shawndalton commented 5 years ago

DPSMate build: 130

Dec/21 14:30:00 - 12: Event not parsed yet => Your Viper Sting drains 277 Mana from Gordok Warlock. You gain 277 Mana. Dec/21 15:11:23 - 16: Event not parsed yet => Reginald Windsor is killed by Death Touch.

Road-block commented 5 years ago

DPSMate build: 130 beta 18

Dec/22 14:37:21 - 12: Event not parsed yet => Your Viper Sting drains 277 Mana from Scarshield Warlock. Dec/22 14:42:28 - 12: Event not parsed yet => Your Viper Sting drains 277 Mana from Spirestone Lord Magus. Dec/22 14:43:13 - 12: Event not parsed yet => Your Viper Sting drains 277 Mana from Spirestone Ogre Magus. Dec/22 14:47:24 - 12: Event not parsed yet => Your Viper Sting drains 277 Mana from Smolderthorn Mystic.

lvangh commented 5 years ago

As a non-programmer w/ very little experience, I wonder how this is being handled in code. I assume that you have to manually input all these events, but isn't that ridiculously time consuming considering there's thousands of possible combinations? Wouldn't that add thousands of lines of code to the LUA file? Why isn't there a way just to filter the event type and ignore /not handle the events? Forgive my ignorance, just curious.

shawndalton commented 5 years ago

DPSMate build: 130

Dec/23 00:29:28 - 16: Event not parsed yet => Living Poison is killed by Explode.

shawndalton commented 5 years ago

DPSMate build: 130

Dec/23 00:45:08 - 30: Event not parsed correctly : You have slain [player]!