GekidoLukas / weaponleveling

8 stars 5 forks source link

incompatibility with IDF #49

Open Arekkusubillaga opened 7 months ago

Arekkusubillaga commented 7 months ago

incompatibility with Improve damage framework, both mods works amazing for a RPG adventure, but seems those are incompatible, i tried to get a crash but just print the default error 1, and couldn't find anything in the log
latest.log

I'm working in a small RPG modpack for friends and this is the mods I'm using for combat

better combat

just leveling

passive skill tree

improved damage frame work

and finally I wanted to add weapon leveling

Arekkusubillaga commented 7 months ago

I addressed the creator of IDF and he said there no much he can do " There's nothing I can do from my end. Weapon Leveling is trying to mixin to a method I absolutely need to overwrite for IDF to work. You can ask the author of Weapon Leveling to try and find an alternate method. That would be the only way. The method is LivingEntity$actuallyHurt " so i would like to know if there any work around or is not possible ?

GekidoLukas commented 7 months ago

Hmm, well I could maybe make a specific compatibility for IDF, but I need to see if that is possible on my end. LivingEntity$actuallyHurt is very important for my methods to function properly. I will look into idf's code to figure out if I can do something

GekidoLukas commented 7 months ago

Hello, so I checked the code for IDF and there are multiple issues. I have to use the actuallyHurt method, since there is the place the damage reduction for armor gets calculated. Also IDF modifies the attribute modifiers and thus calls the ItemStack$getAttributeModifiers method. This causes my mod to crash since it injects there to check if the item is levelable. The issue is, that there is no config available to check for, since the game is not loading a server.

I don't know if there will be any compatibility in general, which is very sad, since their mod is very cool