search

GemTalk / Jadeite

IDE for GemStone Smalltalk application development using Rowan code management
MIT License
6 stars 2 forks source link

Cleanup references to unsent JadeServer methods #829

Open ericwinger opened 4 years ago

ericwinger commented 4 years ago

Running ClassOrganizer new sentButNotImplementedReport one sees numerous entries for JadeServer methods that are unsent on the server. While some are still being called from the Jadeite client, many are obsolete and should be removed.

Full list is here: 20200702 sentButNotImplemented.txt

ericwinger commented 4 years ago

Not going to impact anything but server tests. Still we should clean this up before the 3.6 release. Labeling as Critical so it won't get lost.

dalehenrich commented 4 years ago

Actually, the server tests will be run against an extent without Rowan installed, so it isn't as critical as it once was ... OTOH, it should be cleaned up before we start work on 3.7 ... I would prioritize V2.0 GUI ahead of the SNI ...

LisaAlmarode commented 2 years ago

The list is very long; it would be good to do a pass for cleanup.

ericwinger commented 2 years ago

I've made a pass at removing methods. Here's the new unsent methods report. 20220825_newNotImplemented_after_JadeServer_mass_purge.txt

LisaAlmarode commented 1 year ago

Still more cleanup needs to be done, so not sure why this was closed. I don't suppose it's urgent for first release, though.

ericwinger commented 1 year ago

The original (unwritten) request was to shorten the list of unsent methods that (I think) showed up in lint. That was done. While more work can be done, it didn't seem there was an immediate need to do more and "cleanup" is a never ending task so closing seemed appropriate.