search

GemTalk / Jadeite

IDE for GemStone Smalltalk application development using Rowan code management
MIT License
6 stars 2 forks source link

(3.2.10) need to be able to specify an http url in 'Load project spec' dialog ... #939

Closed dalehenrich closed 1 year ago

dalehenrich commented 2 years ago

I've recently updated Rowan v3 to take an https:// or a file:// url when specify the url for a load spec, however if I enter an https: url for a load spec (https://raw.githubusercontent.com/dalehenrich/RowanSample9/master/specs/spec_0006.ston) I get a FileDoesNotExistException (see attached stack).

To differentiate, we could require a file url (use 'xxx' asRwUrl) to determine if a file: or https: scheme is being used ...

stack.txt

ericwinger commented 2 years ago

Currently, Jadeite prepends 'file:' in front of the Path entered before the server receives the install command from the dialog. However, we could add two radio buttons in the lower left of the Load Project Spec gui - file url. If url is selected, the Path would be taken as-is and prepended with: 'https'. Otherwise, if file is selected, the path would be constructed like it is now. Then, the asUrl call would do the right thing on the server.

Thoughts? @LisaAlmarode @dalehenrich

image

LisaAlmarode commented 2 years ago

For the record, I'm in favor of radio buttons. Probably default to file and then turn it to file if the users has activity in the file selection areas.

ericwinger commented 1 year ago

There's a new URL tab on the load project dialog from which the user can copy/paste a url to load.