search

GemTalk / Jadeite

IDE for GemStone Smalltalk application development using Rowan code management
MIT License
6 stars 2 forks source link

[3.2.12] poolDictionaries are not handled #964

Open LisaAlmarode opened 1 year ago

LisaAlmarode commented 1 year ago

Jadeite does not have any support for pool dictionaries.

There aren't any in the image, as far as I can determine; except Dale has carefully hidden several classes with pool dictionaries deep inside, but I was able to ferret them out. You can make one visible using this code:

| symdic |
symdic := ((AllUsers userWithId: 'DataCurator') symbolList first at: #PackageLibrary) at: 2.
UserGlobals at: #DeflateStream put: (symdic at: #DeflateStream)

While supporting pool dictionaries would be nice, it's not critical for end-2022, but the above do need to be addressed.

dalehenrich commented 1 year ago

This is a case where Rowan does not support pool dictionaries (at the moment) ... To specify a pool dictionary in GemStone you have to pass in a live object ... and live objects are stored in class definitions ... so this isn't really a Jadeite bug ...

ericwinger commented 1 year ago

Should a Rowan issue be created? If so, should this be retired or is there Jadeite work to do?

LisaAlmarode commented 1 year ago

In Jadeite, the definition shows in the browser does not match the classes's definition. I'm not sure where this comes from, but it ought to match (first check box, above).

image image

This might be a rowan issue.

If you try to fill in the poolDictionary: #() argument of any old class, e.g.

Object rwSubclass: 'SomeTestClass' instVarNames: #() classVars: #() classInstVars: #() poolDictionaries: {Pool} category: 'RS10-Lisa1' options: #()

You get a walkback; an error dialog would be more appropriate here. If the template is coming from Rowan then it would be a rowan issue, but I don't know where it comes from.

ericwinger commented 1 year ago

Filed issue https://github.com/GemTalk/Rowan/issues/878 for resolution to this part of the issue: 

the pool dictionaries are not displayed in the jadeite project browser. This is wrong.