GemTalk / Jadeite

IDE for GemStone Smalltalk application development using Rowan code management
MIT License
6 stars 2 forks source link

[3.1.1-pr4] Method Browser - Remove from List removes from system #975

Open rjsargent opened 1 year ago

rjsargent commented 1 year ago

Jadeite Oscar-3.1.1-pre-release4 I had asked for the senders of a commonly sent selector. In my stone, it was #assert:. There were many, many senders, so I thought I would clear out the ones that were sent from test classes, since they are expected to understand #assert:. There were about 90 such methods before the first one I was interested in.

In my first attempted, I selected methods from just about the one I was interested in to the top of the list. In attempting to remove them from the list, I got a VM error and the Gem went away. I don't recall exactly when that occurred, but I think it must have been when I right clicked to pop up the menu that would allow me to remove them from the list. It is possible that I saw the menu and selected Remove from List before the VM error pop up presented.

On my second attempt, I selected only the first five methods, triggered the menu pop up, and selected Remove from List. The Method Browser updated like it had removed them from the list. I was feeling paranoid by this time, so I opened a second Method List browser with the #assert: senders. It displayed the same subset as the original browser did! A Changes browser on the project confirmed that the methods were removed from the system, not just from the browser's list.

LisaAlmarode commented 1 year ago

This does not reproduce in 3.2.12; the Method List Browser remove from list removes from the list but does not remove from the system. After selecting a large range, it did take a while to return with these methods and everything briefly went white, so there might be a performance issue, but it came back and I was able removed them from the list without creating changes.