GemTalk / Jadeite

IDE for GemStone Smalltalk application development using Rowan code management
MIT License
6 stars 2 forks source link

[3.2.13] Jadeite should support both legacy string comparison mode and unicode comparison mode #978

Open ericwinger opened 1 year ago

ericwinger commented 1 year ago

Based on Dale's comments, it sounds like this option should be turned on so Jadeite can support unicode method compilation. But need to wait until Rowan is ready to support unicode. https://github.com/GemTalk/Rowan/issues/877

dalehenrich commented 1 year ago

My guess is that it will be up to the user to on Unicode mode, but this is all premature … we need to understand all of the issues involved before moving forward

dalehenrich commented 1 year ago

I am not aware of the recommendations that make when folks decide to use Unicode source in topaz … and since topaz does not automatically turn on Université comparisons I don’t think Jadeite should either

ericwinger commented 1 year ago

fwiw - My simplistic tests show that nothing special needs to be done to save a method in topaz with a unicode character. So perhaps you're right that this isn't necessary (except to get around the comparison error encountered in the aforementioned comment?)

ericwinger commented 1 year ago

Correction - In topaz, when the method exists, compiling it again with a unicode string requires Unicode16 _useUnicodeComparePrimitives: true

LisaAlmarode commented 1 year ago

Retitle since unicode mode became (declaratively, not verified) required for 3.2.13 while everything isn't actually working. Waiting on 3.7 server issues with GsFilein.