Closed dalehenrich closed 3 years ago
This error was hit while testing the addition of the Announcements project, see GemTalk/Sparkle#51
reproduced the bug using RwRowanSample9Test>>testSpec_0064_2 ... according to the RwProjectSetModification, there is a moved class (the class in the duplicate package), but there is no RwPackageMove created ... we do have an RwPackageMove class, but it is not used ... so it seems that we've now got a use case!
fixed as of 10cb3b1
Upon further review, it seems that while the projects loaded without error (this tests passing), but the loaded package structure is not correct after the load ... it seems that the package that should have moved did not ...
The code that I "commented out" seems to be needed sooner than I anticipated
okay ... progress ... the packages are associated with the Announcements loaded project (rowanProjectName
is correct), but the loaded packages are NOT REGISTERED with the loaded project, so the list of packages in the loaded project is still empty (and the package still show up Sparkle) ... inch by inch :)
the test/patch in fb7afbd represents the exact test case that triggered this bug report, however, it is now prudent to extend the test cases to include changes to the class and methods in the moved package to ensure that we've covered just about all of the possibilties
with commit dfef7ec, this bug is now well and truly fixed ... additional test coverage passing
Here are the SHAS of the loaded projects:
Here are the SHAS of the incoming projects:
Here's the stack: