search

GemTalk / Rowan

a new project/package manager for Smalltalk that supports FileTree and Tonel repositories, and is independent of Monticello and Metacello
MIT License
14 stars 7 forks source link

(v3.0) STONReaderError improvement -- no file or line number info for duplicate class/method definition Error #896

Closed dalehenrich closed 6 months ago

dalehenrich commented 1 year ago

default STONReaderError provides a character position in the file, but when it does provide the character position, the information about the particular error (aString) is lost:

STONReaderError signal: aString streamPosition: streamPosition

and only the character position is reported:

            [ ^ STON fromStream: stream ]
                on: STONReaderError
                do: [ :ex | Error signal: ex asString , ' while reading ' , registryFile pathString ] ]

... if you do the following you don't see the characterPosition:

            [ ^ STON fromStream: stream ]
                on: STONReaderError
                do: [ :ex | Error signal: ex messageText , ' while reading ' , registryFile pathString ] ]
dalehenrich commented 1 year ago

related to internal bug 50263

dalehenrich commented 8 months ago

reopening to address internal bug "50858 P3 no file or line number info for duplicate class definition Error"

dalehenrich commented 6 months ago

As of 7de29df, this bug is fixed

dalehenrich commented 6 months ago

Reopening, since he 896 test cases were not complete ...

dalehenrich commented 6 months ago

Add test cases for the two more forms of the error ... including file and line number info