GemTalk / Rowan

a new project/package manager for Smalltalk that supports FileTree and Tonel repositories, and is independent of Monticello and Metacello
MIT License
14 stars 7 forks source link

(v3) need test case for adopting an unmanaged class when an incoming package takes ownership of the class #919

Open dalehenrich opened 7 months ago

dalehenrich commented 7 months ago

The class RwGsClassUnmanagedVersioningSymbolDictPatchV2 was created to handle this case and it is not correctly handled during the load.

Working on Rowan4GsDevKit, I have an unmanaged class that exists in the system, but needs to be adopted first and that should be done during RwGsPatchSet_V2>>updateSymbolAssociations which is called BEFORE RwGsPatchSet_V2>>updateClassProperties, however, #installNewClassVersionInSystem is skipped because the class exists in RwGsPatchSet_V2>>movedClassesSymbolList ... it's just that the class is not packaged...

dalehenrich commented 7 months ago

Basic test is passing, but we need more extensive tests cases: