GemTalk / Sparkle

MIT License
11 stars 5 forks source link

Spec2 menu buttons are fundamentally broken #33

Closed martinmcclure closed 3 years ago

martinmcclure commented 3 years ago

Sparkle uses menu buttons for all of its menus, rather than right-click context menus or toolbar menus. I recently discovered that the approach that Spec2 takes to menu buttons is flawed. Spec2 tries to display the menu as a Morphic submenu. A morphic submenu expects its parent to be a MenuMorph, and sends its parent messages that only MenuMorphs understand.

Research is needed to discover what menu support Morphic offers that actually works. Once we have something working at the Morphic level, we should be able to fairly easily construct the Spec2 adapter and presenter classes we need.

martinmcclure commented 3 years ago

Fixed by commit 1d521891 of Dec. 30. Full menu functionality requires changes to Spec2 recently merged to P9. This is there by build 1029.