search

GemTalk / Sparkle

MIT License
11 stars 5 forks source link

Send GsProcess>>_isTerminated before performing a debugger action #63

Closed ericwinger closed 2 years ago

ericwinger commented 3 years ago

Working on some new debugger code, doing a stepOver, got the attached error. In the GsProcess, the arStack variable was nil. Allen tracked it to primitive 719 which does have some logic for nil'ing that inst var if the process has been terminated.

The likely scenario was the somehow the process had been terminated before the stepOver took place. A recommendation is to do send _isTerminated to the process before any debugger action takes place that would continue the execution.

Need to discuss with @dalehenrich at some point.

20210324 Stack not convertable error.txt

martinmcclure commented 3 years ago

This is fixed in the tools layer, and a process terminating unexpectedly from under the debugger will result in a process terminated pane.

martinmcclure commented 2 years ago

Through quite a few server and Sparkle tools changes to termination, I think this is no longer a problem. Please reopen or re-file if the problem persists.