GemTalk / Sparkle

MIT License
11 stars 5 forks source link

Stepping gets stuck #81

Closed martinmcclure closed 3 years ago

martinmcclure commented 3 years ago

Dale noted in #78 the following, which I'm splitting out into this issue, since it's not directly relevant to that issue.

Interestingly enough single stepping through this method from the first halt gets stuck on badKeys := Array new. in topaz ... which is a bug that Eric and I have seen with sparkle (scaffolding) and topaz before ... but this is a reproducible test case and I've reported it to Allen (via slack) ...

in topaz, using continue (I assume that is what the "green button" is) repeatedly ends up with a series of UncontinuableErrors:

topaz 1> where ==> 1 UncontinuableError (AbstractException) >> _signalToDebugger @10 line 6 2 UncontinuableError (AbstractException) >> _signalWith: @14 line 33 3 UncontinuableError (AbstractException) >> signal @2 line 47 4 ImproperOperation (Object) >> _error:args: @15 line 11 5 ImproperOperation (Object) >> _uncontinuableError @2 line 5 6 ImproperOperation (AbstractException) >> _signalFromPrimitive: @21 line 28 7 Array (SequenceableCollection) >> select: @19 line 24 8 ChangesFinder class >> testDebug @6 line 7 9 Executed Code @2 line 1 10 GsNMethod class >> _gsReturnToC @1 line 11

This is running this code:

testDebug
    | keys badKeys |
    keys := {'cat'.
    'draw'.
    'apple'}.
    self halt.
    badKeys := Array new.
    badKeys
        addAll:
            (keys
                select: [ :ea | 
                    ea trimSeparators size ~= ea size.
                    self halt ]).
    ^ badKeys printString

Since Topaz also reproduces this problem, it appears to be a base server problem. I'm recording it here in case other Sparkle users/testers notice it.

Notes:

martinmcclure commented 3 years ago

This has now been fixed in 3.7.0.