Gemba / skyscraper

Powerful and versatile game data scraper written in Qt and C++.
https://gemba.github.io/skyscraper/
GNU General Public License v3.0
55 stars 14 forks source link

Bugfix/windows build support whitespace in path #16

Closed retrobit closed 10 months ago

retrobit commented 10 months ago

From issue: https://github.com/Gemba/skyscraper/issues/11

If user home or build path contained white space, build was failing on Windows

For some reason, shell_quote() qmake function when calling powershell -Command md -Force ... was not treated as a single string with white space, but rather multiple strings separated by white space

Attached are text output and screenshot artifacts of build failure (before) and build success (after)

build failure build failure.txt build success build success.txt