search

Gemba / skyscraper

Powerful and versatile game data scraper written in Qt and C++.
https://gemba.github.io/skyscraper/
GNU General Public License v3.0
55 stars 14 forks source link

Segmentation fault when running with invalid frontend name #28

Closed Nargash closed 9 months ago

Nargash commented 9 months ago

Describe the bug If you supply an invalid frontend name in the config file or via the command line, Skyscraper ungracefully crashes with the message "Segmentation fault (core dumped)"

Note this happens even if you supply the write frontend name but with the wrong case.

To Reproduce Run Skyscraper with an invalid frontend. For example: Skyscraper -p snes -s screenscraper -f Pegasus

Expected behavior We should tell the user the frontend is invalid, and perhaps print out a list of valid names

Special circumstances This was running Linux Mint which is case sensitive for many more things than other platforms like Windows might be. But this probably not due to filesystem case sensitivity.

Technical information

Gemba commented 9 months ago

Thanks for the detailed report.

It is not a regression in 3.10.0 but a legacy issue no one tested ever.

Nevertheless, consider it fixed soon.

Nargash commented 9 months ago

Thanks so much for getting to this quickly and for continuing this project!

On Sat, Feb 17, 2024 at 3:11 AM Gemba @.***> wrote:

Closed #28 https://github.com/Gemba/skyscraper/issues/28 as completed via d4c2d61 https://github.com/Gemba/skyscraper/commit/d4c2d61f5266542c19e5076fbfa0dde25135ff19 .

— Reply to this email directly, view it on GitHub https://github.com/Gemba/skyscraper/issues/28#event-11835879524, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGB6T2YDH4ZX4QRSJ7LKP2LYUBQZRAVCNFSM6AAAAABDDYUPACVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRHAZTKOBXHE2TENA . You are receiving this because you authored the thread.Message ID: @.***>