Gemba / skyscraper

Powerful and versatile game data scraper written in Qt and C++.
https://gemba.github.io/skyscraper/
GNU General Public License v3.0
46 stars 14 forks source link

aliasMap.csv not working with Screenscraper #55

Closed retropiuser closed 6 months ago

retropiuser commented 6 months ago

Hi, it's me again :)

I came across this issue and saw you already worked on it and made some fix here and here. It doesn't work for me, but maybe I just don't know how to use aliasMap.csv properly.

Problem description So I have some roms that weren't scraped, among them: /home/pi/RetroPie/roms/gbc/Arle's Adventure - Magical Jewels (Japan) (SGB Enhanced) (GB Compatible) [T-En by Jazz v1.0] [n].zip /home/pi/RetroPie/roms/gbc/Catz (Europe).zip

I added these lines to my aliasMap.csv (residing at /opt/retropie/configs/all/skyscraper):

Arle's Adventure - Magical Jewels (Japan) (SGB Enhanced) (GB Compatible) [T-En by Jazz v1.0] [n];Arle No Bouken - Mahou No Jewel
Catz (Europe);Catz - Your Virtual Petz Palz

I scraped gbc again, via the Retropie script. But still these roms aren't found even though they are in the database: Arle: https://www.screenscraper.fr/romsinfos.php?plateforme=10&alpha=A&numpage=3 https://www.screenscraper.fr/rominfos.php?romid=166110 Catz: https://www.screenscraper.fr/romsinfos.php?plateforme=10&alpha=C&numpage=2 https://www.screenscraper.fr/rominfos.php?romid=166249

Am I doing it wrong? Does it only work from the console? Do I need to edit aliasMap.csv differently? If so, the guide is not clear enough (at least for me).

Technical information

Gemba commented 6 months ago

Well spotted, you found the cause by yourself (the "wrong" commit): I have not put a release 3.11 out yet, thus there is no tag and the scriptmodule of RetroPie does not find a newer version.

However you can benefit from the latest changes with this trick:

Locate this line in the skyscraper.sh scriptmodule. Disable the original line. Then make it read like this (note the absence of the _get_branch_skyscraper part):

#rp_module_repo="git https://github.com/Gemba/skyscraper :_get_branch_skyscraper"
rp_module_repo="git https://github.com/Gemba/skyscraper"

With that you should be able to build with the latest source commit from the retropie_setup menu. (FYI: The aliasMap.csv format has not changed since the original version of Lars's Skyscraper.)

retropiuser commented 6 months ago

Thanks a lot. Though with this change it's not working yet, that is, I can't reinstall skyscraper anymore. In the retropie setup menu, in the skyscraper menu, the option to re-install is not listed anymore and above the options it reads "Install options disabled: curl: (22) The requested URL returned error: 404"

Gemba commented 6 months ago

Obviously the retropie_setup.sh (dialog based) does some extra checks. (I usually install with sudo RetroPie-Setup/retropie_package.sh skyscraper).

Could you change the line again and add master at the end:

rp_module_repo="git https://github.com/Gemba/skyscraper master"

That way it should also be installable from source via the retropie_setup.sh dialogs, at least it does on my side.

retropiuser commented 6 months ago

Thanks, that did the trick. :) Now on the use of aliasMap.csv - Catz got scraped, Arle's Adventure did not. Any idea why? Could the entry in aliasMap still be improved? Maybe it's an outlier, I will try with some more roms.

retropiuser commented 6 months ago

So I scraped some more. Unfortunately, I had hoped for some more hits. Here are the entries for fds I added to aliasMap, broken up into those that worked and those that didn't, so 4 out of 22:

Working:

Bodycon Quest I - Girls Exposed (Japan) (Unl) [T-En by DvD Translations Rev A] [n];Bodycon Quest I - Abakareshi Musume Tachi
Cursed Treasure of Cleopatra, The (Japan) [T-En by DvD Translations Rev A] [n];Cleopatra No Mahou
Demonic Castle Dracula (Japan) (Rev 2) (Disk Writer) [T-En by DvD Translations Rev A] [n];Akumajou Dracula
Miracle of Almana, The (Japan) [T-En by DvD Translations Rev A] [n];Arumana No Kiseki

Not working:

Aspic - Curse of the Snakelord (Japan) [T-En by BlackPaladin v1.0] [n];Aspic - Mahebiou no Noroi
Boxxle - Warehouse Evening of Tears Special (Japan) [T-En by KingMike's Translations v1.0] [n];Namida No Soukoban Special 
Dandy - The Resurrection of Zeuon (Japan) [T-En by Stardust Crusaders v1.00] [n];Dandy - Zeuon No Fukkatsu
Deep Dungeon II - The Hero's Crest (Japan) [T-En by KingMike's Translations v1.0] [HP Unfix] [n];Deep Dungeon 2 - Yuushi No Monshou
Druid - The Gate of Fear (Japan) [T-En by BlackPaladin v1.0] [n];Druid - Kyoufu No Tobira
Idol Hotline - Miho Nakayama's Tokimeki High School (Japan) [T-En by FCandChill & Filler & TheMajinZenki & Graphicus v1.0] [n];Idol Hotline - Nakayama Miho No Tokimeki High School
Kamen Rider Black - The Shadow Moon Showdown (Japan) [T-En by BlackPaladin v1.0] [n];Kamen Rider Black - Taiketsu Shadow Moon
Kitten's Tale, A - The Adventures of Chatran (Japan) [T-En by BlackPaladin v1.0] [corrected] [n];Koneko Monogatari - The Adventures Of Chatran
Mysterious Ghost World - The Turbulent Chapters (Japan) (Rev 1) (Disk Writer) [T-En by BlackPaladin v1.0] [n];Kikikai-kai - Dotou Hen
Mysterious Murasame Castle, The (Japan) [T-En by Spinner 8 and friends v1.1] [n];Nazo No Murasamejou
Myth of Light, The - Palutena's Mirror (Japan) (Rev 1) [T-En by BlackPaladin v1.0] [n];Hikari Shinwa - Palutena no Kagami
Relics - The Dark Fortress (Japan) [T-En by BlackPaladin v1.0] [n];Relics - Ankoku Yousai
Return of Mario Bros. (Japan) (Disk Writer) [T-En by FCandchill & Her-Saki v1.0] [n];Kaettekita Mario Bros.
SD Gundam - Gachapon Soldier - Scramble Wars [T-En by MrRichard999 v1.01] [n];Sd Gundam World - Gachapon Senshi - Scramble Wars
Santa Claus's Toybox (Japan) [T-En by Gil Galad v1.01] [n];Santa Claus No Takarabako
Seiken Psycho Calibur (Japan) [T-En by The Spoony Bard v1.0] [n];Seiken Psychocalibur - Majuu No Mori Densetsu
Sword of Kalin, The (Japan) [T-En by KingMike's Translations v1.0] [n];Kalin No Tsurugi
Temple Labyrinth Dababa (Japan) [T-En by FlashPV v1.0] [n];Meikyuu Jiin Dababa

I wasn't able to find a pattern. Anything I can do to get more hits? Why isn't it working for the latter ones?

Gemba commented 6 months ago

Thanks for providing the samples: The culprit was that filenames with more than one dot got cut off on the first dot and then no match was found in the aliasmap. I fixed that #56, should be ok now.

retropiuser commented 6 months ago

So there is a pattern. Didn't see that coming. Works for me, thanks a lot for the quick fix! :)