search

Gemeente-DenHaag / mijndenhaag-pwa

Progressive Web App based on React and Gatsby for the MijnDenHaag personal environment.
Other
1 stars 1 forks source link

Feature/issue 17 page header #27

Closed DanielvanVliet closed 3 years ago

DanielvanVliet commented 3 years ago

Currently the Icons are missing due to missing components in the component library. I added a placeholder Icon from MUI icons, using a custom Icon did not integrate very well with our MUI based components. To fix this I added an issue for adding icons to the component library instead. When those are added we can replace this placeholder.

Besides this, the <MenuItem>component has a missing property, see issue 19 on the nlds-react-components repo. Until this is merged we can use a ts-ignore.

GewoonMaarten commented 3 years ago

The desktop layout looks good, but the mobile variant does not. Was responsiveness also a requirement?

Probably not that important, as the components haven't even been styled yet.

DanielvanVliet commented 3 years ago

The desktop layout looks good, but the mobile variant does not. Was responsiveness also a requirement?

I believe there is no design for mobile yet, so i did not consider it.

@mjcarsjens Do we need to wait for a mobile design for the homepage before merging this?

DanielvanVliet commented 3 years ago

Appbar is no longer inside the Header component, which makes more sense and allows top navigation to be added under it later.

DanielvanVliet commented 3 years ago

Blocked until sprint 6 merge 1 is merged, then the imports can be fixed and ts-ignore can be removed

DanielvanVliet commented 3 years ago

Ready for review once again