search

Gemeente-DenHaag / mijndenhaag-pwa

Progressive Web App based on React and Gatsby for the MijnDenHaag personal environment.
Other
1 stars 1 forks source link

Sprint 7 merge 1 #49

Closed DanielvanVliet closed 3 years ago

DanielvanVliet commented 3 years ago

This PR contains the following issues:

Additionally, the following changes have been made:

mjcarsjens commented 3 years ago

Quick question: is the linter configuration here working or are we running a different linter config for the PWA?

I noticed the lack of ; line-endings here, while these are used in our component library.

bddjong commented 3 years ago

Quick question: is the linter configuration here working or are we running a different linter config for the PWA?

I noticed the lack of ; line-endings here, while these are used in our component library.

The configuration is working, but we're using a slightly different config from the component library. We have an issue to enforce a consistent style configuration for all three repositories. https://github.com/Gemeente-DenHaag/mijndenhaag-pwa/issues/52 Which combines well with a consistent Husky config issue https://github.com/Gemeente-DenHaag/mijndenhaag-pwa/issues/46