search

Gemeente-DenHaag / mijndenhaag-pwa

Progressive Web App based on React and Gatsby for the MijnDenHaag personal environment.
Other
1 stars 1 forks source link

Create consistent linting for PWA, Gateway and Component Library #52

Open bddjong opened 3 years ago

bddjong commented 3 years ago

Currently, the linter configuration between each repository is not the same. For the most pleasant developer experience, we should ensure the configuration is consistent between all repositories. Due to the maturity of the component library, it's a good idea to use it as a reference for the other repositories.

This issue combines well with consistent commit flow for all repositories #46. Adding the linters to Husky will enforce the styling on each commit.

Acceptance criteria

note: Gateway doesn't use React. Keep this in mind when installing plugins for eslint.

ogjtech commented 3 years ago

While I agree some things should be consistent across all repos (how many tabs per indentation, casing, etc.), I do not think they should be identical 1:1 just because they're made in the same stack (FEG doesn't use React, but all projects are using TypeScript).

They all serve a different purpose, two of which are basically just defining a set of functions and definitions, and one is actually implementing functionality. I do agree with keeping some codestyle configs consistent across the repos, but we should differentiate between what makes sense for which project.