search

GemeenteUtrecht / bereikbaarheid-frontend

De frontend voor de bereikbaarheidskaart
https://kaart.nationaalwegenbestand.nl/bereikbaarheid
Mozilla Public License 2.0
1 stars 0 forks source link

bug door #29

Closed bbussink closed 2 months ago

bbussink commented 2 months ago

Describe the bug The code expects from the RDW API a value with the name maximum_massa_samenstelling (which does not exist anymore, at least not in all cases)

To Reproduce

  1. Go to https://kaart.nationaalwegenbestand.nl/bereikbaarheid with license plate bxls14 and height 4 meter
  2. Click on go with checkboxes unchecked
  3. See error image

Expected behavior the page should show the RDW results but does not

Screenshots I believe the problem is the following. on the left the code expects a column in the RDW data with the name 'maximum_massa_samenstelling' this column does not exist in the API (anymore) so it seems. It used to be there and return a value. This is the url of the API of RDW https://opendata.rdw.nl/api/id/m9d7-ebf2.json?kenteken=BXLS14 image

So the bug is i believe on this page https://github.com/GemeenteUtrecht/bereikbaarheid-frontend/blob/main/src/api/rdw/vehicle/index.ts

Additional context The relevance of this value, if I remember correctly, is to check whether or not the vehicle weight together with the weight of the load should be lower then maximum_massa_samenstelling . If this value does not exist the code breaks. As a quick fix the maximum value could be hard coded as 60000 kg. Later it can replaced in a better way.

Also on the RDW webpage https://ovi.rdw.nl/ the value is 0 (problaby not existing and then defaulting to 0 ) image

sidneygijzen commented 2 months ago

Hi @bbussink

Thank you for the detailed report. Unfortunately I cannot reproduce the issue. When I enter the provided license plate and vehicle height, the page shows the RDW results.

A possible explanation for the experienced issue could be that the RDW was fixing a data delta issue yesterday. Please see this forum post for more details.

Additionally, in the linked Amsterdam issue, you reported everything works as expected. So, I am closing this issue for now. Feel free to reopen if you have any additional questions.