search

GeminiDRSoftware / DRAGONS

Data Reduction for Astronomy from Gemini Observatory North and South
Other
26 stars 17 forks source link

`detector_name()` for GMOS should include info from the `DETECTOR` keyword #101

Open KathleenLabrie opened 3 years ago

KathleenLabrie commented 3 years ago

The detector_name() descriptor for GMOS should incorporate information from the DETECTOR keyword. For example, for Hamamatsu GMOS-S, when the video board was changed, the CCDs remained the same and only the DETECTOR keyword can differentiate between post and pre. See the table below for examples.

Warning: Changing detector_name() would have implications for the GMOS lookup tables in gemini_instruments. So we probably want to discuss this a bit to avoid a mess.

Not urgent. This is not causing issues right now as it appears that changing the video board did not affect gains, etc. It just seems like we should be able to distinguish between changes in instrument hardware with the potential of affecting DR.

  FILE                       detector_name()               detector_name(pretty)     DETECTOR (keyword)
N20030630S0059.fits:   EEV9273-16-03EEV9273-20-04EEV9273-20-03 | EEV     |   GMOS + Red1
N20040423S0015.fits:   EEV9273-16-03EEV9273-20-04EEV9273-20-03 | EEV     |   GMOS + Red1
N20050423S0198.fits:   EEV9273-16-03EEV9273-20-04EEV9273-20-03 | EEV     |   GMOS + Red1
N20100701S0346.fits:   EEV9273-16-03EEV9273-20-04EEV9273-20-03 | EEV     |   GMOS + Red1
N20120401S0203.fits:   e2v 10031-23-05,10031-01-03,10031-18-04 | e2vDD   |   GMOS + e2v DD CCD42-90
N20170418S0090.fits:   BI13-20-4k-1,BI12-09-4k-2,BI13-18-4k-2 | Hamamatsu-N |   GMOS-N + Hamamatsu
S20030119S0039.fits:   EEV8056-20-03EEV8194-19-04EEV8261-07-04 | EEV     |   GMOS + Blue1
S20040715S0037.fits:   EEV2037-06-03EEV8194-19-04EEV8261-07-04 | EEV     |   GMOS + Blue1 + new CCD1
S20070630S0108.fits:   EEV2037-06-03EEV8194-19-04EEV8261-07-04 | EEV     |   GMOS + Blue1 + new CCD1
S20080630S0054.fits:   EEV2037-06-03EEV8194-19-04EEV8261-07-04 | EEV     |   GMOS + Blue1 + new CCD1
S20100630S0083.fits:   EEV2037-06-03EEV8194-19-04EEV8261-07-04 | EEV     |   GMOS + Blue1 + new CCD1
S20140623S0133.fits:   BI5-36-4k-2,BI11-33-4k-1,BI12-34-4k-1 | Hamamatsu-S |   GMOS + Hamamatsu
S20140903S0141.fits:   BI5-36-4k-2,BI11-33-4k-1,BI12-34-4k-1 | Hamamatsu-S |   GMOS + Hamamatsu
S20170620S0057.fits:   BI5-36-4k-2,BI11-33-4k-1,BI12-34-4k-1 | Hamamatsu-S |   GMOS + Hamamatsu_new
S20170620S0133.fits:   BI5-36-4k-2,BI11-33-4k-1,BI12-34-4k-1 | Hamamatsu-S |   GMOS + Hamamatsu_new
KathleenLabrie commented 3 years ago

Maybe a pretty_long option that would combine the output of detector_name(pretty=True) and the value of the DETECTOR keyword. I would hate the make the primary pretty value ugly.

Eg.
detector_name(pretty=True) => "EEV" detector_name(pretty_long=True) => "EEV GMOS + Red1"

KathleenLabrie commented 3 years ago

Note that the pretty=False string for GMOS detector_names() are completely atrocious. (But very specific when it comes to distinguishing detector flavours.)