GeminiDRSoftware / DRAGONS

Data Reduction for Astronomy from Gemini Observatory North and South
Other
27 stars 16 forks source link

Incomplete provenance in output of NIRI's makeProcessedBPM recipe #440

Open KathleenLabrie opened 1 year ago

KathleenLabrie commented 1 year ago

The NIRI makeProcessedBPM requires a list of flats and a list of short darks. In the output BPM, the PROVENANCE table shows the flats but it does not show the darks. It seems to be related to the fact that the darks are transferred to a stream.

The PROVENANCE table says that the provenance on the flats was added by prepare. prepare saw the darks confirmed that , the darks were sent to a stream much later. So, somehow, the info about the darks gets removed. I had a quick look at the code and couldn't really figure out how to fix that.

To reproduce quickly, download this debug package: https://drive.google.com/file/d/1l031lwA-aNU6DwmMTjK3s9nzYi0Y6GMU/view?usp=sharing

Then run reduce @flats.lis @darks1s.lis -r makeProcessedBPM.

To inspect the PROVENANCE table:

$ python
>>> import astrodata, gemini_instruments
>>> ad = astrodata.open('N20160102S0373_bpm.fits')
>>> ad.PROVENANCE