Fix pval calc for low t values

GenABEL-Project / OmicABELnoMM

OmicABELnoMM implements a high-performance computing algorithm for linear regression of omics data

GNU General Public License v3.0

1 stars 3 forks source link

Fix pval calc for low t values #3

Open avsmith opened 7 years ago

avsmith commented 7 years ago

P-values for T < 1.6 incorrectly calculated. Change to erfc based calculation for all T, no major performance hit detected (in limited testing).

Proposed fix for "fixes #2"

lckarssen commented 7 years ago

Hi Albert,

Thanks again for sending this patch. I finally found the time to look at it in more detail. In order to keep things a bit clean (and let the pull request only fix the actual Issue) I have taken the other parts of your commits and applied them separately on master. Could you rebase your changes on top of the current HEAD of master?

Thanks!

avsmith commented 6 years ago

yup, miscommited.