search

GenDeathrow / Hatchery

Be a real life chicken farmer. Hatching, Breeding, and More!
https://minecraft.curseforge.com/projects/hatchery
21 stars 18 forks source link

Animal Net Dupe #23

Closed Y0ungSandwich closed 7 years ago

Y0ungSandwich commented 7 years ago

This doesn't seem like an issue with your mod but maybe with sponge servers. Can not duplicate in SSP.

After placing an animal with the net, anywhere, it doesn't clear the animal net. You can now right click and duplicate the last grabbed chicken. Anything you could possibly look into?

GenDeathrow commented 7 years ago

Strange, it could be sponge, cause I have seen server not dupe chickens. Not sure what on sponge could be causing it. I will look into though.

Y0ungSandwich commented 7 years ago

Thanks so much. At the very least maybe even allowing other mod items to place the chickens in the nest? Like the golden lasso from EU2 comes to mind.

I did try to reproduce this in SSP and a standard Forge server. Only happens on our sponge server.

GenDeathrow commented 7 years ago

Thanks for testing, adding in other items like the lasso was on the list, I just hadn't had the time. plus I got some bug fixing that has to get out. I do appreciate you testing it out. I have not run sponge before. If there is a way to make both happy I will.

Y0ungSandwich commented 7 years ago

That would be amazing. Some authors just aren't caring at all about Sponge and its really putting a damper on some communities. Thanks for the positive outlook!

GenDeathrow commented 7 years ago

I fixed something on my end. that my have been causing the dupe. I didn't get a look at it in sponge yet. but I think the fix for something else may have fixed this issue as well. please get back with me ASAP

Y0ungSandwich commented 7 years ago

Great I'll update and test today after work.

GenDeathrow commented 7 years ago

I hope I unintentionally fixed it.. I realized the nets weren't dumping the entity from its nbt data. In forge you cant spawn to entities with the same ID number, but I bet sponge just gives it a new id.

Y0ungSandwich commented 7 years ago

Unfortunately it is still duping the chickens

GenDeathrow commented 7 years ago

well.. that just makes zero sense, can you send me a video of it happening? "ShareX" < good program for that. make sure to show tooltip of the item before and after placing/duping. also make sure your not in creative / OP.. although I doubt those are doing it.

I not completely sure whats happening now. I am deleting the data after the chicken is placed. so it shouldn't dupe.

Y0ungSandwich commented 7 years ago

Sure I'll get that to you after work tomorrow. Away from my pc for the night.

Y0ungSandwich commented 7 years ago

Again tried it without sponge and it worked fine. Here it is with sponge.

http://mechandmagic.com/animalnet.mp4

Y0ungSandwich commented 7 years ago

Also in addition to the golden lasso I believe soul vials from EnderIO might be a nice additional item to place chickens.

GenDeathrow commented 7 years ago

I'm not sure what sponge/forge are doing together, cause I am using the correct method to remove the entity from the item via NBT removal, So it shouldn't work. Its very confusing

Broklyndatroll commented 7 years ago

I am also having this same issue on the SF3 server our Network has set up. I used an Animal Net to pick up one of the Nether Chickens I liberated via Golden Lasso from Hell, and placed it into a Nesting Pen. But now my Net is basically functioning as a Wand of Nether Chickens. Not only is this a Duping issue, but unless I make multiple Nets, there is no way to place higher stat/generation chickens into the Nesting Pens to further my breeding.

Loving the implementation of the Agricraft breeding model to Chickens though!

GenDeathrow commented 7 years ago

Guys I have been talking with about 5-6 other mod dev's, They are all having issues with Sponge. TBH I cant support something that is obviously not my fault. I kept open mind about it at first, but something isn't right on their end.

My animal net code isn't anymore clear on what it's doing.. it places a chicken and deletes the data from the net via nbt. Even built into forge is a way to prevent entities with the same UUID being place. But Sponge seems to be ignoring it.

The moment they get this problems sorted out I will re-look at these issue.

Y0ungSandwich commented 7 years ago

Understandable. You've been a great help and support with bug fixes so far so thank you for that. Any chance of looking at how EU or EnderIO might do it? Having no issues with any other mod with a net type of item.

GenDeathrow commented 7 years ago

I'll look again and we will see. But Ive got a couple of other projects that need attention.

GenDeathrow commented 7 years ago

Was fixed via Sponge.

https://github.com/SpongePowered/SpongeCommon/commit/4648e4af32f68b07690df05d5446a5b74b99f2b2

Y0ungSandwich commented 7 years ago

Watching and saw, thank you for your help!

GenDeathrow commented 7 years ago

not that I did much, but atleast it got looked at.

ktole1999 commented 7 years ago

anyone know what sponge version this was fixed in?