GenDeathrow / MoreChickens

5 stars 14 forks source link

More Refined Storage #64

Open JayJay1989 opened 5 years ago

JayJay1989 commented 5 years ago

This adds More Refined Storage chicken:

Crystalized Nugget

JamesYeoman commented 5 years ago

Are you sure you've tested your changes actually work and the chicken gets created? Because I've been trying to get it to work but your MoreRefinedStorage mod seems to be a tad borked

image

JayJay1989 commented 5 years ago

I'm pretty sure it works. I recompiled 'More Refined Storage', 'Nevoka-core' and 'More Chickens' with my changes. http://prntscr.com/pi70op http://prntscr.com/pi6zk4 http://prntscr.com/pi6zo7

JayJay1989 commented 5 years ago

Below the compiled mods mods.zip

JamesYeoman commented 5 years ago

Well, using the versions available on curseforge it crashes. These are the mods I have in the mods directory of the run directory image

I would be able to help with debugging/diagnosing if I had access to the source but I had to decomp and deobb your mod in order to be able to actually figure out what was blowing up in there. It seems like Settings.crystalizedBlock isn't actually instantiated in time. That kinda makes sense seeing as though it's a public static property so you have no control over when it can be accessed.

Could you do something for me on your end? Could you test it after removing any config files from the run directory? I think that might be the issue here (relying on config that isn't present)

JayJay1989 commented 5 years ago

Well, using the versions available on curseforge it crashes. These are the mods I have in the mods directory of the run directory image

I would be able to help with debugging/diagnosing if I had access to the source but I had to decomp and deobb your mod in order to be able to actually figure out what was blowing up in there. It seems like Settings.crystalizedBlock isn't actually instantiated in time. That kinda makes sense seeing as though it's a public static property so you have no control over when it can be accessed.

Could you do something for me on your end? Could you test it after removing any config files from the run directory? I think that might be the issue here (relying on config that isn't present)

Can you contact me on discord? https://discord.gg/Hu9RwdE

JamesYeoman commented 5 years ago

I've just joined that server (MemeLord)