GenEpiO / genepio

The Genomic Epidemiology Application Ontology describes the genomics, laboratory, clinical and epidemiological contextual information required to support data sharing and integration for foodborne infectious disease surveillance and outbreak investigations.
Other
18 stars 10 forks source link

There are 1090 unsatisfiable classes in GenEpiO #48

Closed dillerm closed 1 year ago

dillerm commented 1 year ago

I ran the HermiT reasoner on the latest release of GenEpiO and it identified 1090 classes as being unsatisfiable (see attached Excel file). For example, I believe the first class in the list--'cartesian coordinate system' (STATO:0000009)--is unsatisfiable because its parent class--'coordinate system' (STATO:0000010)--is asserted to be a subclass of 'information content entity' (a generically dependent continuant) and 'n-dimensional concept' (an independent continuant). STATO:0000010 is also unsatisfiable and included in the list.

unsatisfiable_classes_genepio.xlsx

ddooley commented 1 year ago

Sorry for delay in response. Thanks for reporting this. I did run a reasoner on it and found some malformed data types which have now been fixed. Now, although Hermit didn't return that list of unsatisfiable classes that you had (Did you use the Github version of genepio.owl?) I did discover that our import of EFO terms was causing information content entity and other high-level BFO terms to be positioned under their 'experimental factor' class. I've adjusted the EFO import to fix this. Could you let me know if your run of the reasoner still faults the GitHub /genepio.owl file?

dillerm commented 1 year ago

This was for what looks to be the previous release (2021-05-24). Everything looks good on my end.