GenEpiO / genepio

The Genomic Epidemiology Application Ontology describes the genomics, laboratory, clinical and epidemiological contextual information required to support data sharing and integration for foodborne infectious disease surveillance and outbreak investigations.
Other
16 stars 10 forks source link

gitignore additions? #69

Closed cmrn-rhi closed 3 months ago

cmrn-rhi commented 8 months ago
          The src/ontology/genepio-full.owl and src/ontology/genepio.owl files don't really need to be included in the pull request since they are byproducts of build process.  You could leave them in this time since they are already there but in future they don't have to be included.  We could put them in the gitignore file I guess.

Originally posted by @ddooley in https://github.com/GenEpiO/genepio/pull/68#pullrequestreview-1680748964

@ddooley so just confirming there will never be a case when we need these files? Because if s, yes I agree that they should be added to gitignore.

ddooley commented 8 months ago

Yes, that's right, they are intermediary products that don't get referenced by anyone/thing. genepio.owl gets copied up to root on "make prepare_release" or whatever the latest ODK release command is.

cmrn-rhi commented 8 months ago

Thank you. I'll add them to the gitignore on my next branch.