Avoiding popup blockers

GenFirst / react-twitter-auth

A React Twitter Login Component

MIT License

93 stars 52 forks source link

Avoiding popup blockers #3

Closed tishko closed 6 years ago

coveralls commented 6 years ago

Coverage decreased (-0.7%) to 17.857% when pulling c56530877322477eadce87acdf510e6580b74fec on tishko:feature/openPopup into d9085584f1e6456d1b6d99692a478803cb1dc14b on GenFirst:master.

ivanvs commented 6 years ago

Hi @tishko,

Firstly, I would like to thank you for your valuable contribution. I really appropriate your help. I will test you PR tomorrow and most likely I will then release the new version with your fix.

Could you just change URL creation to use template literals, as I wrote in review I think it is easier to read?

coveralls commented 6 years ago

Coverage decreased (-0.7%) to 17.857% when pulling e08b117296d67e9596ef517ec08f0b8814d6b66f on tishko:feature/openPopup into d9085584f1e6456d1b6d99692a478803cb1dc14b on GenFirst:master.

coveralls commented 6 years ago

Coverage decreased (-0.7%) to 17.857% when pulling cd9d28246721a6ae4caf5c0af83162a225a094e4 on tishko:feature/openPopup into d9085584f1e6456d1b6d99692a478803cb1dc14b on GenFirst:master.

coveralls commented 6 years ago

Coverage decreased (-0.7%) to 17.857% when pulling cd9d28246721a6ae4caf5c0af83162a225a094e4 on tishko:feature/openPopup into d9085584f1e6456d1b6d99692a478803cb1dc14b on GenFirst:master.

coveralls commented 6 years ago

Coverage decreased (-1.0%) to 17.544% when pulling 64ba47c3ef37b24539bfdc776adef03f887703b5 on tishko:feature/openPopup into d9085584f1e6456d1b6d99692a478803cb1dc14b on GenFirst:master.

coveralls commented 6 years ago

Coverage decreased (-0.7%) to 17.857% when pulling 94a510ee9a92d371eef641234c95a42a33c45200 on tishko:feature/openPopup into d9085584f1e6456d1b6d99692a478803cb1dc14b on GenFirst:master.

ivanvs commented 6 years ago

Thank you for your awesome contribution. I have merged the pull request and created a new release of library: v0.0.9.