GenPi64 / Build.Dist

Build scripts for building GenPi64 images.
Other
11 stars 10 forks source link

Jan 14 2023 poole #185

Closed jlpoolen closed 1 year ago

jlpoolen commented 1 year ago

I'm submitting 4 files modified: 3 have "-p" added to mkdir. 1 has whitespace before shebang removed.

When I built anew, there was a problem with a subdirectory not being created at first, a bug which would only manifest itself on an initial run. I see no harm in having all mkdirs with -p.

jonesmz commented 1 year ago

Squash your commits into a single commit.

git rebase origin/master -i

edit the resulting file as appropriate following the in-file instructions

git commit --amend --no-edit
git push -f
jlpoolen commented 1 year ago

I apologize for the delay. I'm really struggling here to use git. Can you recommend a site which covers git. This try-to-learn git peace-meal as needed simply is not working for me. I'll make a commitment to learn git and do practice stuff with a test repository until I'm satisfied I know what I'm doing in git. I have enough problems with Subversion and branching which I avoid if I can because it just seems to get me into trouble. In the meantime, in the interest of efficiency, perhaps you can effectuate a patch that replaced "mkdir" with your custom chmkdir at the places I identified you agreed needed improvement so the benefit of the change does not get delayed due to my incompetency of using git.

samip5 commented 1 year ago

I apologize for the delay. I'm really struggling here to use git. Can you recommend a site which covers git. This try-to-learn git peace-meal as needed simply is not working for me. I'll make a commitment to learn git and do practice stuff with a test repository until I'm satisfied I know what I'm doing in git. I have enough problems with Subversion and branching which I avoid if I can because it just seems to get me into trouble. In the meantime, in the interest of efficiency, perhaps you can effectuate a patch that replaced "mkdir" with your custom chmkdir at the places I identified you agreed needed improvement so the benefit of the change does not get delayed due to my incompetency of using git.

Maybe this helps: https://www.youtube.com/watch?v=SWYqp7iY_Tc

jlpoolen commented 1 year ago

I apologize for the delay. I'm really struggling here to use git. Can you recommend a site which covers git. This try-to-learn git peace-meal as needed simply is not working for me. I'll make a commitment to learn git and do practice stuff with a test repository until I'm satisfied I know what I'm doing in git. I have enough problems with Subversion and branching which I avoid if I can because it just seems to get me into trouble. In the meantime, in the interest of efficiency, perhaps you can effectuate a patch that replaced "mkdir" with your custom chmkdir at the places I identified you agreed needed improvement so the benefit of the change does not get delayed due to my incompetency of using git.

Maybe this helps: https://www.youtube.com/watch?v=SWYqp7iY_Tc

Thank you. I'm plowing through https://git-scm.com/book/en/v2. I really won't be able to spend much time until after February 1st, so don't expect anything in the next week.

jlpoolen commented 1 year ago

Excellent sleuthing.

I'm afraid divining whitespace as to whether they are ASCII 32 characters or tabs belies the fragility of using whitespace whose effect may be ambiguous. Sharing my criticism reminds me of the lad claiming the Emperor is not clothed.

On Sat, Jul 29, 2023 at 8:50 AM kaoru inoue @.***> wrote:

@.**** commented on this pull request.

In parsers/rawcommand/rawcommand https://github.com/GenPi64/Build.Dist/pull/185#discussion_r1278315792:

cat <<- EOF > "${PROJECT_DIR}/chroot/em-$$"

  • !/usr/bin/env bash

@jonesmz https://github.com/jonesmz CC: @jlpoolen https://github.com/jlpoolen Sorry for commenting after so much time. I came across this comment because I thought it might be a problem with this file. The comment at the reference URL ( https://linuxize.com/post/bash-heredoc/ ) says the following.

Appending a minus sign to the redirection operator <<-, This allows you to use indentation. This allows you to use indentation when writing here-documents in shell scripts. Leading whitespace characters are not allowed, only tab.

It does remove tabs. For example, other hear-documents, such as Build.Dist/parsers/emerge/emerge are tabs.

To me it looked like the commit was erasing all whitespace. But it can also work by changing it to tabs.

— Reply to this email directly, view it on GitHub https://github.com/GenPi64/Build.Dist/pull/185#discussion_r1278315792, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABXP4O47EZ7ZGG32RFHI23XSUWM7ANCNFSM6AAAAAAT3V2UA4 . You are receiving this because you were mentioned.Message ID: @.***>

-- John L. Poole

707-812-1323 @.***

jlpoolen commented 1 year ago

Please do whatever will move this issue to a successful resolution. Mike and I had hoped I would learn about GIT pulls, but since my retirement from programming six months ago, I have had little gumption to undertake mastering GIT. Therefore, you offer to create a new and separate pull request would be a welcomed contribution. Thank you. https://www.ak-modul-bus.de/

On Sun, Jul 30, 2023 at 1:17 AM kaoru inoue @.***> wrote:

@.**** commented on this pull request.

In parsers/rawcommand/rawcommand https://github.com/GenPi64/Build.Dist/pull/185#discussion_r1278529083:

cat <<- EOF > "${PROJECT_DIR}/chroot/em-$$"

  • !/usr/bin/env bash

@jlpoolen https://github.com/jlpoolen Thank you for your reply! https://github.com/GenPi64/Build.Dist/pull/185#issuecomment-1656768581 (I thought it would be easier to understand the context if I commented on the corrections, so I'll comment here.)

I agree that spaces and tabs are confusing. However, I myself feel that it is easier to understand if there is an indentation. This rawcommand issue makes image creation difficult, so can I create another pull request( for this file only )?

— Reply to this email directly, view it on GitHub https://github.com/GenPi64/Build.Dist/pull/185#discussion_r1278529083, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABXP4OZRHJSOTVDYAH5UC3XSYKBHANCNFSM6AAAAAAT3V2UA4 . You are receiving this because you were mentioned.Message ID: @.***>

-- John L. Poole

707-812-1323 new email:* @. @.> old gmail.com http://gmail.com account is being phased out*

jlpoolen commented 1 year ago

This is so stale and tin-machine looks to have submitted what was needed; I'm closing this as stale.