search

GenSpectrum / LAPIS-SILO

Sequence Indexing engine for Large Order of genomic data
GNU Affero General Public License v3.0
12 stars 3 forks source link

More invalid API queries in tests #147

Open Taepper opened 1 year ago

Taepper commented 1 year ago

Currently the verification of user input is not exhaustive and cause crashes of SILO. After we meet the functionality demands of COVID-LAPIS we should extensively increase the testing of faulty inputs

fengelniederhammer commented 1 year ago 
[2023-07-04 17:46:53.486] [console_logger] [info] [query_handler.cpp:29] received query: {"action":{"type":"Details","fields":["division","age","pango_lineage"]},"filterExpression":{"children":[{"column":"division","value":"Basel-Stadt","type":"StringEquals"}],"type":"And"}}
[2023-07-04 17:46:53.486] [console_logger] [debug] [query_engine.cpp:33] Parsed query: (division = 'Basel-Stadt')
[2023-07-04 17:46:53.486] [console_logger] [error] [error_request_handler.cpp:19] Caught exception: _Map_base::at
Taepper commented 1 year ago

Also include tests with invalid user data. (Duplicate/missing primary keys, wrong datatypes, primary keys of sequence files not matching metadata file -> missing in metadata, missing in sequence data)