GenSpectrum / LAPIS-SILO

Sequence Indexing engine for Large Order of genomic data
GNU Affero General Public License v3.0
12 stars 3 forks source link

Make maybe-mode disableable #171

Closed chaoran-chen closed 1 month ago

chaoran-chen commented 1 year ago

The Maybe expressions are needed for CoV-Spectrum but for many other use cases/users, I imagine that they won't be needed. Would we be able to save a lot of memory if they are disabled?

(@Taepper)

Taepper commented 1 year ago

Hmm, I anyways had a change of ambiguous symbol storage in mind, as those indexes are mostly empty. But yes, we can save some memory by that. As it will not really slow down maybe queries, I would not make it disableable which would require us to maintain two versions. I would suggest that we just optimise less for Maybe queries

Taepper commented 1 month ago

This would increase the code complexity by a lot. Speed and memory would remain largely unaffected