Attempt at splitting legacy in wastewater grid

GenSpectrum / cov-spectrum-website

A web platform to detect and analyze variants of SARS-CoV-2

https://cov-spectrum.org

GNU General Public License v3.0

60 stars 14 forks source link

Closed DrYak closed 5 months ago

DrYak commented 5 months ago

DO NOT MERGE I don't know TypeScript, I don't know what I am doing.

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
cov-spectrum-develop	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 26, 2024 3:25pm

DrYak commented 5 months ago

DrYak commented 5 months ago

Needed improvements:

mocking constants.ts to not have the test constant in the same place as the production constants.
de-duplicate code between WasteWaterSamplingSites and WasteWaterLegacySites
- e.g., wrapper around a common function that accepts a lamba that does either the ".has" or "! .has"

DrYak commented 5 months ago

Code deduplication done.

chaoran-chen commented 5 months ago

Thank you very much, @DrYak for the PR! @JonasKellerer will check out and finalize the code.

Is Basel really a discontinued location? In the plot, there are only very recent data.

chaoran-chen commented 5 months ago

Resolved by #959