search

GenSpectrum / dashboard-components

https://genspectrum.github.io/dashboard-components/
GNU Affero General Public License v3.0
2 stars 0 forks source link

Make `NamedLapisFilter` a nested structure #209

Closed fengelniederhammer closed 6 months ago

fengelniederhammer commented 7 months ago

Currently, prevalence over time accepts it's filters as type NamedLapisFilter = LapisFilter & { displayName: string }.

The mutation comparison component has a similar concept (variants with names), but it uses

interface MutationComparisonVariant {
    lapisFilter: LapisFilter;
    displayName: string;
}

The interfaces should be unified for simplicity. I prefer the MutationComparisonVariant. The NamedLapisFilter has the disadvantage, that we need to take care to filter out the displayName from the object before sending the filter to LAPIS.

This will be a breaking change.

fengelniederhammer commented 7 months ago

Also from a quick look at the code I have the impression that the displayName of the denominator is actually unused.