GenSpectrum / dashboard-components

https://genspectrum.github.io/dashboard-components/
GNU Affero General Public License v3.0
2 stars 0 forks source link

235 make info button mobile friendly #246

Closed JonasKellerer closed 6 months ago

JonasKellerer commented 6 months ago

resolves #235

Summary

The info component, now resizes to a smaller size, when on a small screen. This way it should not go outside of the screen. It still is next to the info button. (When the maintainer of a website decides to put the info button outside of the viewport also the info text will be displayed outside. This can also be the case for the prevalence over time component on mobile view. This issue will be adressed in #234) Also the mutation filter component is redisigned, so it works better with the info button and is more similar to loculus input field.

Screenshot

Bildschirmfoto 2024-05-20 um 12 26 51 Bildschirmfoto 2024-05-20 um 13 33 03

PR Checklist

- [ ] All necessary documentation has been adapted.

vercel[bot] commented 6 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboards-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 7:20am
JonasKellerer commented 6 months ago

I now changed the PR, so it uses floating-ui to show the tooltip info. This can then be used for other tooltip actions, like mutation filter.

This now opens a band stretching from side to side with the info.

On desktop: grafik

On Mobile: grafik

I also tried to look for info buttons an my own websearches. I only found this on amazon: grafik This opens the info in a modal. On mobile the modal comes from the bottom.