search

GenSpectrum / dashboard-components

https://genspectrum.github.io/dashboard-components/
GNU Affero General Public License v3.0
2 stars 0 forks source link

`gs-date-range-selector`: set initial `dateFrom` and `dateTo` values from `initialValue` #256

Closed fengelniederhammer closed 6 months ago

fengelniederhammer commented 6 months ago

resolves #245

Summary

Screenshot

PR Checklist

vercel[bot] commented 6 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboards-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 7:43am
JonasKellerer commented 6 months ago

I'm not sure if this PR adresses the ticket. I think the idea was to set the inital dateFrom and initial dateTo directly. So in the end the selector is set to custom, and the values are set to the dateFrom and dateTo value. There should be no new entry as a customDateRange. @chaoran-chen ?

chaoran-chen commented 6 months ago

Yes, exactly, @JonasKellerer! The goal is to be able to either set a special value such as "past 6 months" or a custom value such as (from 2024-01-12 to 2024-03-15). There should indeed be no new entry in customDateRange.

fengelniederhammer commented 6 months ago

Ah, then I got it wrong. But anyway, this was a bug ;)