GenSpectrum / dashboard-components

https://genspectrum.github.io/dashboard-components/
GNU Affero General Public License v3.0
2 stars 0 forks source link

fix(components): correct sorting with null values in gs-aggregate #309

Closed JonasKellerer closed 5 months ago

JonasKellerer commented 5 months ago

resolves #270

Summary

This fixes the issue, that the sorting with null values did not work. It seems to be a bug in gridjs.

Screenshot

Ascending grafik

Descending grafik

PR Checklist

- [ ] All necessary documentation has been adapted. - [ ] The implemented feature is covered by an appropriate test.

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2024 9:09am
github-actions[bot] commented 5 months ago

This is a preview of the changelog of the next release:

0.5.1 (2024-07-01)

Bug Fixes

JonasKellerer commented 5 months ago

There is already a gridjs issue, but with undefined values. I think a fix of that will resolve our problem as well. I'll add a ticket to check.

JonasKellerer commented 5 months ago

There is now a new issue: https://github.com/GenSpectrum/dashboard-components/issues/312