GenSpectrum / dashboard-components

https://genspectrum.github.io/dashboard-components/
GNU Affero General Public License v3.0
2 stars 0 forks source link

feat(components): remove handleOnBlur function and dispatch event from MutationFilterInner #511

Closed anna-parker closed 1 week ago

anna-parker commented 1 week ago

resolves #

Summary

In https://github.com/GenSpectrum/dashboard-components/pull/500#discussion_r1843558199 we discovered that blur dispatch events are not working as intended. (e.g. it did not fire if a user moved outside of the component if they moved outside after deleting mutations). We decided that this functionality is not needed and is tedious to implement so we will just remove it.

The dispatch event was unused by dashboards (we use the change events dispatch event instead).

Screenshot

PR Checklist

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 0:28am
github-actions[bot] commented 1 week ago

This is a preview of the changelog of the next release. If this branch is not up-to-date with the current main branch, the changelog may not be accurate. Rebase your branch on the main branch to get the most accurate changelog.

Note that this might contain changes that are on main, but not yet released.

Changelog:

0.8.0 (2024-11-15)

⚠ BREAKING CHANGES

Features

fengelniederhammer commented 1 week ago

⚠ BREAKING CHANGES

* **components:** the handle was unused and inaccurate (did not fire after removing mutation queries)

This looks weird by itself - I either repeat the commit message or give instructions what to do. In this case, I would go for the instruction and say something like "removed "..." event from , use ... instead".