Closed JonasKellerer closed 6 days ago
vercel[bot]
commented
1 week ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| dashboard-components | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Nov 21, 2024 0:56am |
github-actions[bot]
commented
1 week ago This is a preview of the changelog of the next release. If this branch is not up-to-date with the current main branch, the changelog may not be accurate. Rebase your branch on the main branch to get the most accurate changelog.
Note that this might contain changes that are on main, but not yet released.
Changelog:
/components. DateRangeOption and dateRangeOptionPresets must be imported from /util
fengelniederhammer
commented
6 days ago I think we should also adapt the breaking changes message to something like "components: the web components must now be imported from ...components.js, DateRangeOption and dateRangeOptionPresets must be imported from ..."
BREAKING CHANGE: DateRangeOption and dateRangeOptionPresets now in own sub package
Summary
When importing our components utility functions (like dateRangeOptionPresets) in a node environment or on the server side of an astro application we get an error, that "HTMLElement not defined". This message occurs, because the lit element class extends HTMLElement. To provide users of our package also access to our utility functions, we put them into an own sub-package. They can now be imported through e.g.:
import { dateRangeOptionPresets } from '@genspectrum/dashboard-components/util';Screenshot
PR Checklist
- [ ] The implemented feature is covered by an appropriate test.