GenSpectrum / dashboards

https://genspectrum.github.io/dashboards/
GNU Affero General Public License v3.0
1 stars 0 forks source link

refactor: use daisyui for tabs and containers #46

Closed JonasKellerer closed 2 months ago

JonasKellerer commented 2 months ago

Summary

Screenshot

grafik

PR Checklist

- [ ] The implemented feature is covered by an appropriate test. (There are no tests yet)

chaoran-chen commented 2 months ago

Would it be possible to leave the tabs at the bottom while minimizing the whitespace?

chaoran-chen commented 2 months ago

Sorry for the very brief comment earlier. The tabs look much better than the previous ones!

To explain what I would like to improve, something that I don't like about the CoV-Spectrum plots is that the actual plots are really small: in this example, the plot only covers 36.8% of the area of a component:

image

With the new design, I tried to minimize the whitespace. Even with the very large title, the plot covers 71% of the area. Hereby, it was a conscious decision to have the tabs on the same row as the scale options (linear/logarithmic) and the question mark button.

image

With the design of this PR, there is more whitespace and the plot only covers 58.8% of the area and I would like to increase the number.

image