search

GenSpectrum / mpox-spectrum-website

https://mpox.genspectrum.org
4 stars 1 forks source link

bug: No date in metadata download for partial dates #8

Closed theosanderson closed 2 years ago

theosanderson commented 2 years ago
image

vs.

image
chaoran-chen commented 2 years ago

This is for some use cases certainly inconvenient but not actually a bug. The thing is that I would like to guarantee that the "date" field contains a proper and complete ISO date or nothing.

See https://mpox-lapis.genspectrum.org/docs/#date-handling

chaoran-chen commented 2 years ago

This way, the API remains easy to use for users who are lazy/don't care about partial dates because they can just take the value in "date" and put it into any default date parsers. People who care about partial dates need to use the "year" and "month" fields.

theosanderson commented 2 years ago

Apologies - I had not taken in the year and month columns! Thanks for the patient reply and sorry for failure to rtfm :)

chaoran-chen commented 2 years ago

Don't worry! Sorry for making changes to the API/introducing new features without communicating them properly.

chaoran-chen commented 2 years ago

(We should introduce release notes.)