GenXProject / GenX.jl

GenX: a configurable power system capacity expansion model for studying low-carbon energy futures. More details at : https://genx.mit.edu
https://genxproject.github.io/GenX.jl/
GNU General Public License v2.0
264 stars 112 forks source link

Make LDES period references consistent with standard storage #522

Open gmantegna opened 1 year ago

gmantegna commented 1 year ago

Currently, storage_all.jl uses functions like "hoursbefore" to do period wrapping whereas long_duration_storage.jl uses harder to read expressions like "hours_per_subperiod*(w-1)+1". The LDES constraints could be made easier to read and work with if they were modified to at least abstract out what these expressions mean, or ideally use a function like storage_all.jl does. cc @cfe316

JesseJenkins commented 5 months ago

@lbonaldo @sambuddhac has this been fixed in v0.4? If not, please address when practical.

sambuddhac commented 5 months ago

@lbonaldo @sambuddhac has this been fixed in v0.4? If not, please address when practical.

Nope !!! This hasn't been done yet. But, happy to take on this.